linux-kernel - RE: [PATCH 4/4] cdx: add sysfs for subsystem, class and revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM4PR12MB7765D5B3FC16399E7A1428898F36A@DM4PR12MB7765.namprd12.prod.outlook.com>
Date:   Wed, 12 Jul 2023 13:23:57 +0000
From:   "Gangurde, Abhijit" <abhijit.gangurde@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Gupta, Nipun" <Nipun.Gupta@....com>,
        "Agarwal, Nikhil" <nikhil.agarwal@....com>,
        "Gupta, Puneet (DCG-ENG)" <puneet.gupta@....com>,
        "git (AMD-Xilinx)" <git@....com>,
        "Simek, Michal" <michal.simek@....com>,
        "Jansen Van Vuuren, Pieter" <pieter.jansen-van-vuuren@....com>
Subject: RE: [PATCH 4/4] cdx: add sysfs for subsystem, class and revision

[AMD Official Use Only - General]

> > RPU provides subsystem_vendor, subsystem_device, class and revision
> > info of the device.
>
> What is "RPU"?

RPU is the remote processor on which firmware runs(controller). Will update the patch description in v2.

>
> > Use the Subsystem vendor id, device id and class
> > to match the cdx device. Subsystem vendor and device combination
> > can be used to identify the card. This identification would be useful
> > for cdx device driver for card specific operations.
>
> Why aren't you binding devices to drivers based on this like all other
> bus types do?

We are using similar binding to match the device to driver. Would update the patch description in v2.

<snip>

> >  /**
> >   * struct cdx_ops - Callbacks supported by CDX controller.
> > @@ -84,6 +99,10 @@ struct cdx_controller {
> >   * @cdx: CDX controller associated with the device
> >   * @vendor: Vendor ID for CDX device
> >   * @device: Device ID for CDX device
> > + * @subsystem_vendor: Subsystem Vendor ID for CDX device
> > + * @subsystem_device: Subsystem Device ID for CDX device
> > + * @class: Class for the CDX device
> > + * @revision: Revision of the CDX device
> >   * @bus_num: Bus number for this CDX device
> >   * @dev_num: Device number for this device
> >   * @res: array of MMIO region entries
> > @@ -101,6 +120,10 @@ struct cdx_device {
> >     struct cdx_controller *cdx;
> >     u16 vendor;
> >     u16 device;
> > +   u16 subsystem_vendor;
> > +   u16 subsystem_device;
> > +   u32 class;
>
> What endian are these attributes?  Please be specific for all of them
> (also for vendor and device, right?)
>

Will update this in v2.

Thanks,
Abhijit