[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <CU08YMZ7867W.ITLC05RV2R69@syracuse>
Date: Wed, 12 Jul 2023 16:01:22 +0200
From: "Nicolas Escande" <nico.escande@...il.com>
To: "Minjie Du" <duminjie@...o.com>,
"Gregory Greenman" <gregory.greenman@...el.com>,
"Kalle Valo" <kvalo@...nel.org>,
"Stephen Rothwell" <sfr@...b.auug.org.au>,
"open list:INTEL WIRELESS WIFI LINK (iwlwifi)"
<linux-wireless@...r.kernel.org>,
"open list" <linux-kernel@...r.kernel.org>
Cc: <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters
check in iwl_mei_dbgfs_register()
On Wed Jul 12, 2023 at 3:14 PM CEST, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return
> in iwl_mei_dbgfs_register().
>
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
> drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> index 54445f39f..e5d203a62 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
> @@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
> {
> mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
>
> - if (!mei->dbgfs_dir)
> + if (IS_ERR(mei->dbgfs_dir))
> return;
same as the other one
>
> debugfs_create_ulong("status", S_IRUSR,
Powered by blists - more mailing lists