linux-kernel - Re: [v2, 2/2] mtd: spinand: winbond: Fix ecc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230712140917.284243-1-miquel.raynal@bootlin.com>
Date:   Wed, 12 Jul 2023 16:09:17 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Olivier Maignial <olivier.maignial@...mail.fr>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>, stable@...r.kernel.org,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Schrempf Frieder <frieder.schrempf@...tron.De>,
        Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [v2, 2/2] mtd: spinand: winbond: Fix ecc_get_status

On Fri, 2023-06-23 at 15:33:37 UTC, Olivier Maignial wrote:
> Reading ECC status is failing.
> 
> w25n02kv_ecc_get_status() is using on-stack buffer for
> SPINAND_GET_FEATURE_OP() output. It is not suitable for
> DMA needs of spi-mem.
> 
> Fix this by using the spi-mem operations dedicated buffer
> spinand->scratchbuf.
> 
> See
> spinand->scratchbuf:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/mtd/spinand.h?h=v6.3#n418
> spi_mem_check_op():
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/spi/spi-mem.c?h=v6.3#n199
> 
> Fixes: 6154c7a58348 ("mtd: spinand: winbond: add Winbond W25N02KV flash support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Olivier Maignial <olivier.maignial@...mail.fr>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel