linux-kernel - Re: [PATCH v2] android: Remove error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023071310-unbounded-alkalize-a491@gregkh>
Date:   Thu, 13 Jul 2023 15:53:20 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wang Ming <machel@...o.com>
Cc:     Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <brauner@...nel.org>,
        Carlos Llamas <cmllamas@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v2]  android: Remove error checking for
 debugfs_create_dir()

On Thu, Jul 13, 2023 at 04:06:37PM +0800, Wang Ming wrote:
> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in binder_init().
> 
> Signed-off-by: Wang Ming <machel@...o.com>
> ---
>  drivers/android/binder.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 486c8271cab7..49d84a6c4594 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6557,6 +6557,7 @@ static int __init binder_init(void)
>  	struct binder_device *device;
>  	struct hlist_node *tmp;
>  	char *device_names = NULL;
> +	const struct binder_debugfs_entry *db_entry;
>  
>  	ret = binder_alloc_shrinker_init();
>  	if (ret)
> @@ -6566,19 +6567,16 @@ static int __init binder_init(void)
>  	atomic_set(&binder_transaction_log_failed.cur, ~0U);
>  
>  	binder_debugfs_dir_entry_root = debugfs_create_dir("binder", NULL);
> -	if (binder_debugfs_dir_entry_root) {
> -		const struct binder_debugfs_entry *db_entry;
>  
> -		binder_for_each_debugfs_entry(db_entry)
> -			debugfs_create_file(db_entry->name,
> -					    db_entry->mode,
> -					    binder_debugfs_dir_entry_root,
> -					    db_entry->data,
> -					    db_entry->fops);
> +	binder_for_each_debugfs_entry(db_entry)
> +		debugfs_create_file(db_entry->name,
> +					db_entry->mode,
> +					binder_debugfs_dir_entry_root,
> +					db_entry->data,
> +					db_entry->fops);
>  
> -		binder_debugfs_dir_entry_proc = debugfs_create_dir("proc",
> -						 binder_debugfs_dir_entry_root);
> -	}
> +	binder_debugfs_dir_entry_proc = debugfs_create_dir("proc",
> +						binder_debugfs_dir_entry_root);
>  
>  	if (!IS_ENABLED(CONFIG_ANDROID_BINDERFS) &&
>  	    strcmp(binder_devices_param, "") != 0) {
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot