linux-kernel - Re: [PATCH v1 2/9] selftests/mm: Give scripts execute permission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac816a32-cea9-363f-4490-19e6f5225c3d@redhat.com>
Date:   Thu, 13 Jul 2023 16:39:33 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Ryan Roberts <ryan.roberts@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>,
        Jérôme Glisse <jglisse@...hat.com>,
        Mark Brown <broonie@...nel.org>,
        John Hubbard <jhubbard@...dia.com>,
        Florent Revest <revest@...omium.org>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        SeongJae Park <sj@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v1 2/9] selftests/mm: Give scripts execute permission

On 13.07.23 15:54, Ryan Roberts wrote:
> When run under run_vmtests.sh, test scripts were failing to run with
> "permission denied" due to the scripts not being executable.
> 
> It is also annoying not to be able to directly invoke run_vmtests.sh,
> which is solved by giving also it the execute permission.
> 
> Signed-off-by: Ryan Roberts <ryan.roberts@....com>
> ---
>   tools/testing/selftests/mm/charge_reserved_hugetlb.sh  | 0
>   tools/testing/selftests/mm/check_config.sh             | 0
>   tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0
>   tools/testing/selftests/mm/run_vmtests.sh              | 0
>   tools/testing/selftests/mm/test_hmm.sh                 | 0
>   tools/testing/selftests/mm/test_vmalloc.sh             | 0
>   tools/testing/selftests/mm/va_high_addr_switch.sh      | 0
>   tools/testing/selftests/mm/write_hugetlb_memory.sh     | 0
>   8 files changed, 0 insertions(+), 0 deletions(-)
>   mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh
> 
> diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh
> old mode 100644
> new mode 100755

Sounds reasonable to me.

Probably due to:

commit baa489fabd01596d5426d6e112b34ba5fb59ab82
Author: SeongJae Park <sj@...nel.org>
Date:   Tue Jan 3 18:07:53 2023 +0000

     selftests/vm: rename selftests/vm to selftests/mm
     
     Rename selftets/vm to selftests/mm for being more consistent with the
     code, documentation, and tools directories, and won't be confused with
     virtual machines.


and indeed, it contains

diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
old mode 100755
new mode 100644
similarity index 100%
rename from tools/testing/selftests/vm/run_vmtests.sh
rename to tools/testing/selftests/mm/run_vmtests.sh


Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb