linux-kernel - Re: [PATCH net-next 2/3] net: qrtr: ns: Change nodes radix tree to xarray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLAQUhAw4yqEW6Y6@corigine.com>
Date:   Thu, 13 Jul 2023 15:55:14 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Vignesh Viswanathan <quic_viswanat@...cinc.com>
Cc:     mani@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-arm-msm@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_srichara@...cinc.com, quic_clew@...cinc.com
Subject: Re: [PATCH net-next 2/3] net: qrtr: ns: Change nodes radix tree to
 xarray

On Wed, Jul 12, 2023 at 04:56:30PM +0530, Vignesh Viswanathan wrote:
> There is a use after free scenario while iterating through the nodes
> radix tree despite the ns being a single threaded process. This can
> happen when the radix tree APIs are not synchronized with the
> rcu_read_lock() APIs.
> 
> Convert the radix tree for nodes to xarray to take advantage of the
> built in rcu lock usage provided by xarray.
> 
> Signed-off-by: Chris Lew <quic_clew@...cinc.com>
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@...cinc.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>