linux-kernel - Re: [PATCH] ext4: fix off by one issue in ext4_mb_choose_next_group_best

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168926009830.3728471.10772472098260314138.b4-ty@mit.edu>
Date:   Thu, 13 Jul 2023 10:55:07 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     linux-ext4@...r.kernel.org, Ojaswin Mujoo <ojaswin@...ux.ibm.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Ritesh Harjani <riteshh@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>,
        Kemeng Shi <shikemeng@...weicloud.com>
Subject: Re: [PATCH] ext4: fix off by one issue in ext4_mb_choose_next_group_best_avail()


On Fri, 09 Jun 2023 16:04:03 +0530, Ojaswin Mujoo wrote:
> In ext4_mb_choose_next_group_best_avail(), we want the start order to be
> 1 less than goal length and the min_order to be, at max, 1 more than the
> original length. This commit fixes an off by one issue that arose due to
> the fact that 1 << fls(n) > (n).
> 
> After all the processing:
> 
> [...]

Applied, thanks!

[1/1] ext4: fix off by one issue in ext4_mb_choose_next_group_best_avail()
      commit: 7c79210b15ef69a5702d1fb817bad9a30bffb097

Best regards,
-- 
Theodore Ts'o <tytso@....edu>