linux-kernel - Re: [PATCH v7 8/9] acpi/nfit: Remove unnecessary .remove callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jDOOhcTcYnDrkWbto1f_XJRs4Yd3huQcRJhhCoBGVcQA@mail.gmail.com>
Date:   Thu, 13 Jul 2023 17:23:47 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Michal Wilczynski <michal.wilczynski@...el.com>,
        dan.j.williams@...el.com
Cc:     linux-acpi@...r.kernel.org, rafael@...nel.org,
        vishal.l.verma@...el.com, lenb@...nel.org, dave.jiang@...el.com,
        ira.weiny@...el.com, rui.zhang@...el.com,
        linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev
Subject: Re: [PATCH v7 8/9] acpi/nfit: Remove unnecessary .remove callback

On Mon, Jul 3, 2023 at 10:03 AM Michal Wilczynski
<michal.wilczynski@...el.com> wrote:
>
> Nfit driver doesn't use .remove() callback and provide an empty function
> as it's .remove() callback. Remove empty acpi_nfit_remove() and
> initialization of callback.
>
> Suggested-by: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Michal Wilczynski <michal.wilczynski@...el.com>

This one is not strictly related to the rest of the series, but it
does depend on the previous one, so assuming that the previous one is
not objectionable, I suppose I can take them both.  Dan?

> ---
>  drivers/acpi/nfit/core.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 124e928647d3..16bf17a3d6ff 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -3402,11 +3402,6 @@ static int acpi_nfit_add(struct acpi_device *adev)
>                                         adev);
>  }
>
> -static void acpi_nfit_remove(struct acpi_device *adev)
> -{
> -       /* see acpi_nfit_unregister */
> -}
> -
>  static void acpi_nfit_update_notify(struct device *dev, acpi_handle handle)
>  {
>         struct acpi_nfit_desc *acpi_desc = dev_get_drvdata(dev);
> @@ -3488,7 +3483,6 @@ static struct acpi_driver acpi_nfit_driver = {
>         .ids = acpi_nfit_ids,
>         .ops = {
>                 .add = acpi_nfit_add,
> -               .remove = acpi_nfit_remove,
>         },
>  };
>
> --
> 2.41.0
>