linux-kernel - Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230713154155.GE968624@google.com>
Date:   Thu, 13 Jul 2023 16:41:55 +0100
From:   Lee Jones <lee@...nel.org>
To:     Henning Schild <henning.schild@...mens.com>
Cc:     Pavel Machek <pavel@....cz>, Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in
 SPDX header

On Wed, 12 Jul 2023, Henning Schild wrote:

> Am Wed, 12 Jul 2023 12:52:52 +0100
> schrieb Lee Jones <lee@...nel.org>:
> 
> > On Thu, 06 Jul 2023, Henning Schild wrote:
> > 
> > > This was found with giving the file to checkpatch.
> > > 
> > > Signed-off-by: Henning Schild <henning.schild@...mens.com>
> > > ---
> > >  drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > > bf258c32f83d..3d4877aa4e0c 100644 ---
> > > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > > -// SPDX-License-Identifier: GPL-2.0
> > > +/* SPDX-License-Identifier: GPL-2.0 */  
> > 
> > What prompted this change?
> > 
> > % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 117
> > % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 2
> > 
> 
> ./scripts/checkpatch.pl --no-tree --file
> drivers/leds/simple/simatic-ipc-leds-gpio.h 
> 
> it boils down to header versus c-file, not sure why headers prefer that
> other style

Ah yes, that one.  Okay.

-- 
Lee Jones [李琼斯]