[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <801dbd65-ee7f-526d-6cd8-27cb0291c4ba@infradead.org>
Date: Thu, 13 Jul 2023 09:02:39 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
Thomas Zimmermann <tzimmermann@...e.de>
Cc: deller@....de, javierm@...hat.com, linux-sh@...r.kernel.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
amd-gfx@...ts.freedesktop.org, linux-input@...r.kernel.org,
linux-media@...r.kernel.org, linux-fbdev@...r.kernel.org,
linux-staging@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org,
linux-geode@...ts.infradead.org, linux-nvidia@...ts.surfsouth.com,
linux-hyperv@...r.kernel.org, linux-omap@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, kvm@...r.kernel.org,
Miguel Ojeda <ojeda@...nel.org>
Subject: Re: [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns
zero'ed data
On 7/13/23 06:21, Miguel Ojeda wrote:
> On Thu, Jul 13, 2023 at 3:03 PM Thomas Zimmermann <tzimmermann@...e.de> wrote:
>>
>> Most fbdev drivers depend on framebuffer_alloc() to initialize the
>> allocated memory to 0. Document this guarantee.
>>
>> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
>> Cc: Helge Deller <deller@....de>
>
> Thanks for sending this! Maybe this would be best earlier in the
> series, so that later patches make more sense (since they use the
> guarantee), but it is not a big deal.
>
>> + * aligned to sizeof(long). Both, the instance of struct fb_info and
>> + * the driver private data, are cleared to zero.
>
> I think both commas may be best omitted (but I am not a native speaker).
Yes, it would be better to omit them.
> Reviewed-by: Miguel Ojeda <ojeda@...nel.org>
>
> Cheers,
> Miguel
--
~Randy
Powered by blists - more mailing lists