linux-kernel - Re: [PATCH v3] ntb: Remove error checking for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a1062c3-f5be-ea69-0672-cf1a44be7e03@intel.com>
Date:   Thu, 13 Jul 2023 09:05:03 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Wang Ming <machel@...o.com>, Jon Mason <jdmason@...zu.us>,
        Allen Hubbe <allenbh@...il.com>,
        Serge Semin <fancer.lancer@...il.com>,
        Dan Carpenter <error27@...il.com>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>, <ntb@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>
CC:     <opensource.kernel@...o.com>, <dan.carpenter@...aro.org>
Subject: Re: [PATCH v3] ntb: Remove error checking for debugfs_create_dir()



On 7/13/23 01:56, Wang Ming wrote:
> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in tool_setup_dbgfs()
> 
> Signed-off-by: Wang Ming <machel@...o.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
>   drivers/ntb/test/ntb_tool.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index eeeb4b1c97d2..e0acc11d29ba 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -1495,8 +1495,6 @@ static void tool_setup_dbgfs(struct tool_ctx *tc)
>   
>   	tc->dbgfs_dir = debugfs_create_dir(dev_name(&tc->ntb->dev),
>   					   tool_dbgfs_topdir);
> -	if (!tc->dbgfs_dir)
> -		return;
>   
>   	debugfs_create_file("port", 0600, tc->dbgfs_dir,
>   			    tc, &tool_port_fops);