linux-kernel - [PATCH v4 00/21] fix DRM_USE_DYNAMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230713163626.31338-1-jim.cromie@gmail.com>
Date:   Thu, 13 Jul 2023 10:36:05 -0600
From:   Jim Cromie <jim.cromie@...il.com>
To:     jbaron@...mai.com, daniel.vetter@...ll.ch,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org
Cc:     jani.nikula@...el.com, ville.syrjala@...ux.intel.com,
        seanpaul@...omium.org, robdclark@...il.com,
        gregkh@...uxfoundation.org, Jim Cromie <jim.cromie@...il.com>
Subject: [PATCH v4 00/21] fix DRM_USE_DYNAMIC_DEBUG regression

hi Jason, Daniel, Greg, etal

Heres another run at the regression, adequately explained in V3 here:
 https://lore.kernel.org/lkml/20230125203743.564009-1-jim.cromie@gmail.com/
 https://patchwork.freedesktop.org/series/113363/

V3 exposed an init-ordering issue with jump-label, fixed by Jason with
7deabd674988 ("dyndbg: use the module notifier callbacks")

These patches are against v6.4, they apply cleanly to drm-next-2023-07-07
Also at https://github.com/jimc/linux.git (dd-fix-2k2, dd-fix-2k-on-drm)


The bulk of the work is in the 2nd of the dyndbg-API commits, it
probably requires the most scrutiny.  It splits the confused
double-duty job of DECLARE_DYNDBG_CLASSMAP into DYNDBG_CLASSMAP_DEFINE
and DYNDBG_CLASSMAP_USE.

The other dyndbg-API patches could stand a wider review, since they
make new API.  Bikeshed on names, now while its easy.  Fresh eyes see
inconsistencies better.

I considered s/class_map/classmap/, since theres also CLASSMAP, and
also PeterZ's new CLASS macros (which I should generally stay away from).
Or is that just churn ?  catmap ??  And maybe *param* fn-names too.

I yanked the NAME class-types, since there are no users except the
test-module, we could have it back later if anyone wants it.

theres also an RFC s/__LINE__/__COUNTER__/ in __UNIQUE_ID fallback.


Jim Cromie (21):
  drm: use correct ccflags-y syntax
  test-dyndbg: fixup CLASSMAP usage error
  dyndbg: make ddebug_class_param union members same size
  dyndbg: replace classmap list with a vector
  dyndbg: ddebug_apply_class_bitmap - add module arg, select on it
  dyndbg: split param_set_dyndbg_classes to module/wrapper fns
  dyndbg: drop NUM_TYPE_ARRAY
  dyndbg: reduce verbose/debug clutter
  dyndbg: silence debugs with no-change updates
  dyndbg: tighten ddebug_class_name() 1st arg type
  dyndbg: tighten fn-sig of ddebug_apply_class_bitmap
  dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code
  dyndbg-API: fix DECLARE_DYNDBG_CLASSMAP & CONFIG_DRM_USE_DYNAMIC_DEBUG
  dyndbg: refactor ddebug_classparam_clamp_input
  dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API
  dyndbg-test: make it build with just CONFIG_DYNAMIC_DEBUG_CORE
  drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN
  compiler.h: RFC - s/__LINE__/__COUNTER__/ in __UNIQUE_ID fallback
  drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers
  config TEST_DYNAMIC_DEBUG default m
  dyndbg-doc: add classmap info to howto

 .../admin-guide/dynamic-debug-howto.rst       |  60 +++
 drivers/gpu/drm/Kconfig                       |   3 +-
 drivers/gpu/drm/Makefile                      |   3 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |  12 +-
 drivers/gpu/drm/display/drm_dp_helper.c       |  12 +-
 drivers/gpu/drm/drm_crtc_helper.c             |  12 +-
 drivers/gpu/drm/drm_gem_shmem_helper.c        |   2 +
 drivers/gpu/drm/drm_print.c                   |  35 +-
 drivers/gpu/drm/gud/gud_drv.c                 |   2 +
 drivers/gpu/drm/i915/i915_params.c            |  12 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c         |   2 +
 drivers/gpu/drm/nouveau/nouveau_drm.c         |  12 +-
 drivers/gpu/drm/qxl/qxl_drv.c                 |   2 +
 drivers/gpu/drm/radeon/radeon_drv.c           |   2 +
 drivers/gpu/drm/udl/udl_main.c                |   2 +
 drivers/gpu/drm/vkms/vkms_drv.c               |   2 +
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c           |   2 +
 include/asm-generic/vmlinux.lds.h             |   1 +
 include/drm/drm_print.h                       |  12 +-
 include/linux/compiler.h                      |   4 +-
 include/linux/dynamic_debug.h                 | 112 +++--
 kernel/module/main.c                          |   3 +
 lib/Kconfig.debug                             |  13 +-
 lib/Makefile                                  |   4 +-
 lib/dynamic_debug.c                           | 399 +++++++++++-------
 lib/test_dynamic_debug.c                      | 127 +++---
 lib/test_dynamic_debug_submod.c               |  10 +
 27 files changed, 522 insertions(+), 340 deletions(-)
 create mode 100644 lib/test_dynamic_debug_submod.c

-- 
2.41.0