linux-kernel - Re: [PATCH v3 0/3] TPMI control and debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 19:48:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     hdegoede@...hat.com, markgross@...nel.org,
        ilpo.jarvinen@...ux.intel.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] TPMI control and debugfs support

On Wed, Jul 12, 2023 at 03:59:47PM -0700, Srinivas Pandruvada wrote:
> The first patch provides interface to read feature status. This is
> generic patch to be used by other feature drivers.
> 
> The second patch add support for debugfs. Debugfs also display
> feature status using the first patch

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

A couple of nit-picks in the individual comments.

> Srinivas Pandruvada (3):
>   platform/x86/intel/tpmi: Read feature control status
>   platform/x86/intel/tpmi: Add debugfs interface
>   doc: TPMI: Add debugfs documentation
> 
>  Documentation/ABI/testing/debugfs-tpmi |  31 ++
>  MAINTAINERS                            |   1 +
>  drivers/platform/x86/intel/tpmi.c      | 399 ++++++++++++++++++++++++-
>  include/linux/intel_tpmi.h             |   2 +
>  4 files changed, 426 insertions(+), 7 deletions(-)
>  create mode 100644 Documentation/ABI/testing/debugfs-tpmi
> 
> -- 
> 2.40.1
> 

-- 
With Best Regards,
Andy Shevchenko