linux-kernel - Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLArgoe3TXF27gsE@smile.fi.intel.com>
Date:   Thu, 13 Jul 2023 19:51:14 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ruihong Luo <colorsu1922@...il.com>
Cc:     ilpo.jarvinen@...ux.intel.com, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, stable@...r.kernel.org,
        luoruihong@...omi.com, weipengliang@...omi.com,
        wengjinfei@...omi.com
Subject: Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF
 register

On Thu, Jul 13, 2023 at 08:42:36AM +0800, Ruihong Luo wrote:
> Preserve the original value of the Divisor Latch Fraction (DLF) register.
> When the DLF register is modified without preservation, it can disrupt
> the baudrate settings established by firmware or bootloader, leading to
> data corruption and the generation of unreadable or distorted characters.

You forgot to add my tag. Why? Do you think the name of variable warrants this?
Whatever,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Next time if you don't pick up somebody's tag, care to explain in the changelog
why.

> Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> Signed-off-by: Ruihong Luo <colorsu1922@...il.com>

-- 
With Best Regards,
Andy Shevchenko