linux-kernel - Re: [PATCH v2 net] gso: fix dodgy bit handling for GSO_UDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-K-fra5nc-pjOV8Ng9sB2WWWeZA=s+-WN=O6+=8aZ-E6w@mail.gmail.com>
Date:   Thu, 13 Jul 2023 13:38:18 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Yan Zhai <yan@...udflare.com>
Cc:     "open list:NETWORKING [TCP]" <netdev@...r.kernel.org>,
        kernel-team@...udflare.com, Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Xin Long <lucien.xin@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Andrew Melnychenko <andrew@...nix.com>,
        Jason Wang <jasowang@...hat.com>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:SCTP PROTOCOL" <linux-sctp@...r.kernel.org>
Subject: Re: [PATCH v2 net] gso: fix dodgy bit handling for GSO_UDP_L4

On Thu, Jul 13, 2023 at 1:28 PM Yan Zhai <yan@...udflare.com> wrote:
>
> Commit 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4
> packets.") checks DODGY bit for UDP, but for packets that can be fed
> directly to the device after gso_segs reset, it actually falls through
> to fragmentation:
>
> https://lore.kernel.org/all/CAJPywTKDdjtwkLVUW6LRA2FU912qcDmQOQGt2WaDo28KzYDg+A@mail.gmail.com/
>
> This change restores the expected behavior of GSO_UDP_L4 packets.
>
> Fixes: 1fd54773c267 ("udp: allow header check for dodgy GSO_UDP_L4 packets.")
> Suggested-by: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Signed-off-by: Yan Zhai <yan@...udflare.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

for next time: places hyperlinks in the block of tags at the bottom of
the commit as "Link: ${URL}"