linux-kernel - Re: [PATCH v5] blk-mq: fix start_time_ns and alloc_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 12:31:17 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     hch@....de, tj@...nel.org, ming.lei@...hat.com,
        chengming.zhou@...ux.dev
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhouchengming@...edance.com
Subject: Re: [PATCH v5] blk-mq: fix start_time_ns and alloc_time_ns for
 pre-allocated rq


On Mon, 10 Jul 2023 18:55:16 +0800, chengming.zhou@...ux.dev wrote:
> The iocost rely on rq start_time_ns and alloc_time_ns to tell saturation
> state of the block device. Most of the time request is allocated after
> rq_qos_throttle() and its alloc_time_ns or start_time_ns won't be affected.
> 
> But for plug batched allocation introduced by the commit 47c122e35d7e
> ("block: pre-allocate requests if plug is started and is a batch"), we can
> rq_qos_throttle() after the allocation of the request. This is what the
> blk_mq_get_cached_request() does.
> 
> [...]

Applied, thanks!

[1/1] blk-mq: fix start_time_ns and alloc_time_ns for pre-allocated rq
      commit: 5c17f45e91f5035c1b317e93b3dfb01088ac2902

Best regards,
-- 
Jens Axboe