linux-kernel - Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3L5QpmPrHZPKVSapPtgDNORb8hj2AhCLGP0Fx7p5ZX++qOOA@mail.gmail.com>
Date:   Thu, 13 Jul 2023 23:08:03 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     airlied@...il.com, daniel@...ll.ch,
        Bogdan Togorean <bogdan.togorean@...log.com>
Subject: Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5

On Tue, May 16, 2023 at 7:44 PM Alexandru Ardelean <alex@...uggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@...log.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>

Ping on this patch :)

> Signed-off-by: Bogdan Togorean <bogdan.togorean@...log.com>
> Signed-off-by: Alexandru Ardelean <alex@...uggie.ro>
> ---
>  drivers/gpu/drm/i2c/adv7511.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
> index 61aa824d45d2..e016105a8fbe 100644
> --- a/drivers/gpu/drm/i2c/adv7511.c
> +++ b/drivers/gpu/drm/i2c/adv7511.c
> @@ -729,8 +729,13 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder,
>         else
>                 low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> -       regmap_update_bits(adv7511->regmap, 0xfb,
> -               0x6, low_refresh_rate << 1);
> +       if (adv7511->type == ADV7511)
> +               regmap_update_bits(adv7511->regmap, 0xfb,
> +                       0x6, low_refresh_rate << 1);
> +       else
> +               regmap_update_bits(adv7511->regmap, 0x4a,
> +                       0xc, low_refresh_rate << 2);
> +
>         regmap_update_bits(adv7511->regmap, 0x17,
>                 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
> --
> 2.40.1
>