linux-kernel - Re: [PATCH v4 15/19] selftests/resctrl: Don't pass test name to fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 16:10:57 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        <linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
        "Shaopeng Tan" <tan.shaopeng@...fujitsu.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 15/19] selftests/resctrl: Don't pass test name to
 fill_buf

Hi Ilpo,

On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> Test name is passed to fill_buf functions so that they can loop around
> buffer only once. This is required for CAT test case.
> 
> To loop around buffer only once, caller doesn't need to let fill_buf
> know which test case it is. Instead, pass a boolean argument 'once'
> which makes fill_buf more generic.
> 
> As run_benchmark() no longer needs to pass the test name to
> run_fill_buf(), a few test running functions can be simplified to not
> write the test name into the default benchmark_cmd. The has_ben
> argument can also be removed now from those test running functions.
> 
> Co-developed-by: Fenghua Yu <fenghua.yu@...el.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette