[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230713053823.14898-1-machel@vivo.com>
Date: Thu, 13 Jul 2023 13:38:08 +0800
From: Wang Ming <machel@...o.com>
To: Rasesh Mody <rmody@...vell.com>,
Sudarsana Kalluru <skalluru@...vell.com>,
GR-Linux-NIC-Dev@...vell.com,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Krishna Gudipati <kgudipat@...cade.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com, Wang Ming <machel@...o.com>
Subject: [PATCH net v1] bna:Fix error checking for debugfs_create_dir()
The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in bnad_debugfs_init() was forgotten.
Fix the remaining error check.
Signed-off-by: Wang Ming <machel@...o.com>
Fixes: 7afc5dbde091 ("bna: Add debugfs interface.")
---
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
index 04ad0f2b9677..678a3668a041 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
@@ -512,7 +512,7 @@ bnad_debugfs_init(struct bnad *bnad)
if (!bnad->port_debugfs_root) {
bnad->port_debugfs_root =
debugfs_create_dir(name, bna_debugfs_root);
- if (!bnad->port_debugfs_root) {
+ if (IS_ERR(bnad->port_debugfs_root)) {
netdev_warn(bnad->netdev,
"debugfs root dir creation failed\n");
return;
--
2.25.1
Powered by blists - more mailing lists