linux-kernel - Re: [PATCH] drivers: wireless: ath5k: fix parameter check in ath5k_debug_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <986bc150-1ab3-4ec1-dd76-d3be69bfcef9@kernel.org>
Date:   Thu, 13 Jul 2023 07:47:53 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Markus Elfring <Markus.Elfring@....de>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Minjie Du <duminjie@...o.com>, linux-wireless@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Cc:     opensource.kernel@...o.com, LKML <linux-kernel@...r.kernel.org>,
        Kalle Valo <kvalo@...nel.org>,
        Nick Kossifidis <mickflemm@...il.com>
Subject: Re: [PATCH] drivers: wireless: ath5k: fix parameter check in
 ath5k_debug_init_device

On 12. 07. 23, 21:07, Markus Elfring wrote:
>>> +++ b/drivers/net/wireless/ath/ath5k/debug.c
>>> @@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
>>>   	ah->debug.level = ath5k_debug;
>>>
>>>   	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
>> -	if (!phydir)
>>> +	if (IS_ERR(phydir))
>>
>> Please use IS_ERR_OR_NULL() instead.
> 
> I find your support for consistent error detection interesting here.
> Contributors for other Linux software components provide different
> development views.

IS_ERR_OR_NULL() is almost never correct. It is used exceptionally in 
cases where one needs to distinct three states. It's not the case for 
sysfs/debugfs interfaces.

> Would a subject like “[PATCH v2] ath5k: Fix an error check in ath5k_debug_init_device()”
> be more appropriate?

Yes (pointing out specifically "()" at the end). And add the "why" part 
to the message log too, please.

thanks,
-- 
js
suse labs