lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Thu, 13 Jul 2023 08:01:08 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     王明-软件底层技术部 
        <machel@...o.com>
Cc:     David Hildenbrand <david@...hat.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: 回复: [PATCH v1] lib:Fix an NULL vs IS_ERR() bug for
 debugfs_create_dir() in err_inject_init()


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Jul 13, 2023 at 02:09:03AM +0000, 王明-软件底层技术部 wrote:
> Hi greg k-h
> I proposed this patch because I found that debugfs_create_dir() does
> not return NULL, but returns an error pointer, executing if statements
> according to the original code meaning no error, so I made this change
> : )

That's fine, but you should fix this up to use the api properly if you
are making these types of changes, otherwise we just have to do it again
in the future.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ