linux-kernel - Re: [PATCH] TIOCSTI: always enable for CAP_SYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a71ee5b3-2d17-e32f-45e1-0c351cdc501b@kernel.org>
Date:   Thu, 13 Jul 2023 08:01:46 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Simon Brand <simon.brand@...tadigitale.de>,
        Kees Cook <keescook@...omium.org>,
        linux-kernel@...r.kernel.org, Dave@...lke.cc
Subject: Re: [PATCH] TIOCSTI: always enable for CAP_SYS_ADMIN

On 10. 07. 23, 2:26, Samuel Thibault wrote:
> 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled") broke BRLTTY's
> ability to simulate keypresses on the console, thus effectively breaking
> braille keyboards of blind users.
> 
> This restores the TIOCSTI feature for CAP_SYS_ADMIN processes, which
> BRLTTY is, thus fixing braille keyboards without re-opening the security
> issue.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>
> Acked-by: Kees Cook <keescook@...omium.org>
> Fixes: 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")
> Cc: stable@...r.kernel.org

Acked-by: Jiri Slaby <jirislaby@...nel.org>

thanks,
-- 
js
suse labs