linux-kernel - Re: [PATCH][next] selftests: ALSA: Fix fclose on an already fclosed file pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871qhcgx7m.wl-tiwai@suse.de>
Date:   Thu, 13 Jul 2023 08:08:29 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Ivan Orlov <ivan.orlov0322@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Shuah Khan <shuah@...nel.org>,
        alsa-devel@...a-project.org, linux-kselftest@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] selftests: ALSA: Fix fclose on an already fclosed file pointer

On Wed, 12 Jul 2023 16:01:22 +0200,
Colin Ian King wrote:
> 
> In the case where a sysfs file cannot be opened the error return path
> fcloses file pointer fpl, however, fpl has already been closed in the
> previous stanza. Fix the double fclose by removing it.
> 
> Fixes: 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Thanks, applied.


Takashi