[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZK-fD7inmxjwPyL5@orome>
Date: Thu, 13 Jul 2023 08:51:59 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Minjie Du <duminjie@...o.com>
Cc: Krishna Reddy <vdumpa@...dia.com>, Joerg Roedel <joro@...tes.org>,
Will Deacon <will@...nel.org>,
Robin Murphy <robin.murphy@....com>,
Jonathan Hunter <jonathanh@...dia.com>,
"open list:TEGRA IOMMU DRIVERS" <linux-tegra@...r.kernel.org>,
"open list:IOMMU SUBSYSTEM" <iommu@...ts.linux.dev>,
open list <linux-kernel@...r.kernel.org>,
opensource.kernel@...o.com
Subject: Re: [PATCH v2] iommu: remove redundant parameter check in
tegra_smmu_debugfs_init()
On Thu, Jul 13, 2023 at 10:56:53AM +0800, Minjie Du wrote:
> debugfs_create_file() will simply return early if
> smmu->debugfs is an error pointer.
The formatting is a little weird here.
> Make smmu->debugfs check delete in tegra_smmu_debugfs_init().
I think something like this is better:
Delete smmu->debugfs check in ...
Or perhaps combine both sentences:
debugfs_create_file() will return early if smmu->debugfs is an error
pointer, so an extra error check is not needed.
With that fixed:
Acked-by: Thierry Reding <treding@...dia.com>
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists