linux-kernel - RE: [PATCH v10 3/7] iommu/vt-d: Add domain_flush_pasid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276E5CEC47C42ACE74CB9328C37A@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Thu, 13 Jul 2023 07:45:39 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        "Robin Murphy" <robin.murphy@....com>
CC:     Jason Gunthorpe <jgg@...dia.com>, Will Deacon <will@...nel.org>,
        "Liu, Yi L" <yi.l.liu@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "Luck, Tony" <tony.luck@...el.com>
Subject: RE: [PATCH v10 3/7] iommu/vt-d: Add domain_flush_pasid_iotlb()

> From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Sent: Thursday, July 13, 2023 12:34 AM
> 
> From: Lu Baolu <baolu.lu@...ux.intel.com>
> 
> The VT-d spec requires to use PASID-based-IOTLB invalidation descriptor
> to invalidate IOTLB and the paging-structure caches for a first-stage
> page table. Add a generic helper to do this.
> 
> RID2PASID is used if the domain has been attached to a physical device,
> otherwise real PASIDs that the domain has been attached to will be used.

this should mention that 'real' PASID attach is not handled in this patch.
Otherwise it's confusing to connect this description to the new helper.

> 
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> ---
>  drivers/iommu/intel/iommu.c | 22 ++++++++++++++++++++--
>  1 file changed, 20 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index ddff43def3ab..40685cbfaf0e 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1467,6 +1467,24 @@ static void iommu_flush_dev_iotlb(struct
> dmar_domain *domain,
>  	spin_unlock_irqrestore(&domain->lock, flags);
>  }
> 
> +/*
> + * The VT-d spec requires to use PASID-based-IOTLB Invalidation to
> + * invalidate IOTLB and the paging-structure-caches for a first-stage
> + * page table.
> + */

this comment is better placed in the calling point. This function has
nothing explicitly connected to first-stage.

with that fixed,

Reviewed-by: Kevin Tian <kevin.tian@...el.com>