linux-kernel - Re: [PATCH] ALSA: pcmtest: Extend error injection, decrease buffer filling overhead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 11:48:14 +0400
From:   Ivan Orlov <ivan.orlov0322@...il.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: pcmtest: Extend error injection, decrease buffer
 filling overhead

On 7/13/23 10:03, Takashi Iwai wrote:
> On Wed, 12 Jul 2023 21:13:25 +0200,
> Ivan Orlov wrote:
>>
>> Extend 'pcmtest' virtual driver with 'open' callback error injection
>> functionality, as it already can inject errors into other PCM callbacks.
>>
>> Fix the driver to use already defined variables where it is possible.
>>
>> Additionally, decrease the buffer filling overhead with conditional
>> reminder calculation in the 'inc_buf_pos' inline function.
>>
>> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>
> 
> Please avoid mixing different changes in a single patch.
> 
> This patch does three completely different things, and they should be
> split.
> 
> - New inject_open_err parameter
> - Optimization of inc_buf_pos()
> - Optimization of check_buf_block_ni() and fill_block_pattern_n()
> 
> The latter two could be put in a single patch as minor optimizations,
> but the introduction of a new option doesn't fit with the rest.
> 
> 
> thanks,
> 
> Takashi

Hi Takashi,

Thank you for the review. I'll split the patch and send the changes again.

Kind regards,
Ivan Orlov