linux-kernel - Re: [PATCH 03/58] mmc: jz4740: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac10f71996d363b8298c9cded7fda5a98675b5ec.camel@crapouillou.net>
Date:   Thu, 13 Jul 2023 10:20:42 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     Yangtao Li <frank.li@...o.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-mips@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/58] mmc: jz4740: Convert to platform remove callback
 returning void

Hi,

Le jeudi 13 juillet 2023 à 16:07 +0800, Yangtao Li a écrit :
> The .remove() callback for a platform driver returns an int which
> makes
> many driver authors wrongly assume it's possible to do error handling
> by
> returning an error code. However the value returned is (mostly)
> ignored
> and this typically results in resource leaks. To improve here there
> is a
> quest to make the remove callback return void. In the first step of
> this
> quest all drivers are converted to .remove_new() which already
> returns
> void.
> 
> Trivially convert this driver from always returning zero in the
> remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/mmc/host/jz4740_mmc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/jz4740_mmc.c
> b/drivers/mmc/host/jz4740_mmc.c
> index 1846a05210e3..f379ce5b582d 100644
> --- a/drivers/mmc/host/jz4740_mmc.c
> +++ b/drivers/mmc/host/jz4740_mmc.c
> @@ -1163,7 +1163,7 @@ static int jz4740_mmc_probe(struct
> platform_device* pdev)
>         return ret;
>  }
>  
> -static int jz4740_mmc_remove(struct platform_device *pdev)
> +static void jz4740_mmc_remove(struct platform_device *pdev)
>  {
>         struct jz4740_mmc_host *host = platform_get_drvdata(pdev);
>  
> @@ -1179,8 +1179,6 @@ static int jz4740_mmc_remove(struct
> platform_device *pdev)
>                 jz4740_mmc_release_dma_channels(host);
>  
>         mmc_free_host(host->mmc);
> -
> -       return 0;
>  }
>  
>  static int jz4740_mmc_suspend(struct device *dev)
> @@ -1198,7 +1196,7 @@ static
> DEFINE_SIMPLE_DEV_PM_OPS(jz4740_mmc_pm_ops, jz4740_mmc_suspend,
>  
>  static struct platform_driver jz4740_mmc_driver = {
>         .probe = jz4740_mmc_probe,
> -       .remove = jz4740_mmc_remove,
> +       .remove_new = jz4740_mmc_remove,
>         .driver = {
>                 .name = "jz4740-mmc",
>                 .probe_type = PROBE_PREFER_ASYNCHRONOUS,