[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1bef1179238e09cdfce281cc2428ba56@kernel.org>
Date: Thu, 13 Jul 2023 11:00:07 +0200
From: Michael Walle <mwalle@...nel.org>
To: Simon Horman <simon.horman@...igine.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Marek BehĂșn <kabel@...nel.org>,
Xu Liang <lxu@...linear.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 08/11] net: phy: add support for C45-over-C22
transfers
Hi Simon,
Am 2023-07-13 10:56, schrieb Simon Horman:
> On Wed, Jul 12, 2023 at 05:07:08PM +0200, Michael Walle wrote:
>
> ...
>
>> @@ -780,6 +782,7 @@ static int get_phy_c45_devs_in_pkg(struct mii_bus
>> *bus, int addr, int dev_addr,
>> * the "devices in package" is invalid.
>> */
>> static int get_phy_c45_ids(struct mii_bus *bus, int addr,
>> + enum phy_access_mode mode,
>
> Please add the new mode parameter to the kernel doc for this function,
> which is in the lines preceding this hunk.
Ahh. Sorry. You've already mentioned that last time :/
Also true for get_phy_c45_devs_in_pkg().
-michael
Powered by blists - more mailing lists