linux-kernel - Re: [PATCH] drm/nouveau/iccsense:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 11:14:16 +0200
From:   Karol Herbst <kherbst@...hat.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     sunran001@...suo.com, airlied@...il.com, daniel@...ll.ch,
        nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/nouveau/iccsense:

On Thu, Jul 13, 2023 at 11:13 AM Karol Herbst <kherbst@...hat.com> wrote:
>
> On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya <bagasdotme@...il.com> wrote:
> >
> > On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran001@...suo.com wrote:
> > > Fixed error: 'do not use assignment in if condition'
> > >
> > > This patch fixes error: 'do not use assignment in if condition'
> > > in drm/nouveau/iccsense
> >
> > I guess this is checkpatch fix, right?
> >
> > >
> > > Signed-off-by: Ran Sun <sunran001@...suo.com>
> > > ---
> > >  drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > index 8f0ccd3664eb..2428f3d6e477 100644
> > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > @@ -322,7 +322,8 @@ int
> > >  nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type type,
> > > int inst,
> > >             struct nvkm_iccsense **iccsense)
> > >  {
> > > -    if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
> > > +    *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
> > > +    if (!*iccsense)
> > >          return -ENOMEM;
> > >      INIT_LIST_HEAD(&(*iccsense)->sensors);
> > >      INIT_LIST_HEAD(&(*iccsense)->rails);
> >
> > Your patch is corrupted (tabs converted to spaces) because you're using
> > Roundcube. Please use git-send-mail(1) instead.
> >
>
> oh right, I didn't notice with the patches I reviewed already here.
> Yeah, none of them apply, please use git to send those patches.
>

also please send them all together in a single series the next time.

> > Thanks.
> >
> > --
> > An old man doll... just what I always wanted! - Clara