[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230713093459.GG10768@google.com>
Date: Thu, 13 Jul 2023 10:34:59 +0100
From: Lee Jones <lee@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Pavel Machek <pavel@....cz>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Henning Schild <henning.schild@...mens.com>,
Arnd Bergmann <arnd@...db.de>,
Hans de Goede <hdegoede@...hat.com>,
linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: simatic-ipc-leds-gpio: restore LEDS_CLASS
dependency
On Fri, 23 Jun 2023, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> A recent rework accidentally lost the dependency on LEDS_CLASS, which
> leads to a link error when LED support is disbled:
>
> x86_64-linux-ld: drivers/leds/simple/simatic-ipc-leds.o: in function `simatic_ipc_leds_probe':
> simatic-ipc-leds.c:(.text+0x10c): undefined reference to `devm_led_classdev_register_ext'
>
> Add back the dependency that was there originally.
>
> Fixes: a6c80bec3c935 ("leds: simatic-ipc-leds-gpio: Add GPIO version of Siemens driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> drivers/leds/simple/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists