linux-kernel - Fwd: [PATCH] hid: Replace snprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 17:40:53 +0800
From:   hanyu001@...suo.com
To:     erazor_de@...rs.sourceforge.net, jikos@...nel.org,
        benjamin.tissoires@...hat.com
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Fwd: [PATCH] hid:  Replace snprintf() with sysfs_emit()

coccinelle report:
./drivers/scsi/mvsas/mv_init.c:699:8-16:
WARNING: use scnprintf or sprintf
./drivers/scsi/mvsas/mv_init.c:747:8-16:
WARNING: use scnprintf or sprintf

./drivers/hid/hid-roccat-kovaplus.c:330:8-16: WARNING: use scnprintf or 
sprintf
./drivers/hid/hid-roccat-kovaplus.c:277:8-16: WARNING: use scnprintf or 
sprintf
./drivers/hid/hid-roccat-kovaplus.c:339:8-16: WARNING: use scnprintf or 
sprintf
./drivers/hid/hid-roccat-kovaplus.c:349:8-16: WARNING: use scnprintf or 
sprintf
./drivers/hid/hid-roccat-kovaplus.c:370:8-16: WARNING: use scnprintf or 
sprintf

Signed-off-by: ztt <1549089851@...com>
---
  drivers/hid/hid-roccat-kovaplus.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/hid/hid-roccat-kovaplus.c 
b/drivers/hid/hid-roccat-kovaplus.c
index 1a1d96e11683..282e26f55074 100644
--- a/drivers/hid/hid-roccat-kovaplus.c
+++ b/drivers/hid/hid-roccat-kovaplus.c
@@ -274,7 +274,7 @@ static ssize_t 
kovaplus_sysfs_show_actual_profile(struct device *dev,
  {
      struct kovaplus_device *kovaplus =
              hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-    return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_profile);
+    return scnprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_profile);
  }

  static ssize_t kovaplus_sysfs_set_actual_profile(struct device *dev,
@@ -327,7 +327,7 @@ static ssize_t kovaplus_sysfs_show_actual_cpi(struct 
device *dev,
  {
      struct kovaplus_device *kovaplus =
              hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-    return snprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_cpi);
+    return scnprintf(buf, PAGE_SIZE, "%d\n", kovaplus->actual_cpi);
  }
  static DEVICE_ATTR(actual_cpi, 0440, kovaplus_sysfs_show_actual_cpi, 
NULL);

@@ -336,7 +336,7 @@ static ssize_t 
kovaplus_sysfs_show_actual_sensitivity_x(struct device *dev,
  {
      struct kovaplus_device *kovaplus =
              hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-    return snprintf(buf, PAGE_SIZE, "%d\n", 
kovaplus->actual_x_sensitivity);
+    return scnprintf(buf, PAGE_SIZE, "%d\n", 
kovaplus->actual_x_sensitivity);
  }
  static DEVICE_ATTR(actual_sensitivity_x, 0440,
             kovaplus_sysfs_show_actual_sensitivity_x, NULL);
@@ -346,7 +346,7 @@ static ssize_t 
kovaplus_sysfs_show_actual_sensitivity_y(struct device *dev,
  {
      struct kovaplus_device *kovaplus =
              hid_get_drvdata(dev_get_drvdata(dev->parent->parent));
-    return snprintf(buf, PAGE_SIZE, "%d\n", 
kovaplus->actual_y_sensitivity);
+    return scnprintf(buf, PAGE_SIZE, "%d\n", 
kovaplus->actual_y_sensitivity);
  }
  static DEVICE_ATTR(actual_sensitivity_y, 0440,
             kovaplus_sysfs_show_actual_sensitivity_y, NULL);
@@ -367,7 +367,7 @@ static ssize_t 
kovaplus_sysfs_show_firmware_version(struct device *dev,
              &info, KOVAPLUS_SIZE_INFO);
      mutex_unlock(&kovaplus->kovaplus_lock);

-    return snprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);
+    return scnprintf(buf, PAGE_SIZE, "%d\n", info.firmware_version);
  }
  static DEVICE_ATTR(firmware_version, 0440,
             kovaplus_sysfs_show_firmware_version, NULL);