linux-kernel - Re: [PATCH v3] i2c: busses: fix parameter check in i2c_gpio_fault_injector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230713095018.3v6qhc3y7bsic6ha@intel.intel>
Date:   Thu, 13 Jul 2023 11:50:18 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Minjie Du <duminjie@...o.com>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com, stable@...r.kernel.org,
        Markus Elfring <Markus.Elfring@....de>
Subject: Re: [PATCH v3] i2c: busses: fix parameter check in
 i2c_gpio_fault_injector_init()

Hi Minje,

as Markus suggested, the title

“i2c: gpio: Fix an error check in i2c_gpio_fault_injector_init()”

looks more appropriate and...

On Thu, Jul 13, 2023 at 10:05:17AM +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return.

... I think you should fix a bit the log here (also Mark has
suggested it). How about something like:

debugfs_create_dir() function returns an error value embedded in
the pointer (PTR_ERR). We need to evaluate the return value using
IS_ERR, rather than checking for NULL.

> Fixes: 14911c6f48ec ("i2c: gpio: add fault injector")
> Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Cc: <stable@...r.kernel.org> # v4.16+
> 

don't leave space between tags.

> Signed-off-by: Minjie Du <duminjie@...o.com>
> Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

At the end it can be something like:

   i2c: gpio: Fix an error check in i2c_gpio_fault_injector_init()
   
   debugfs_create_dir() function returns an error value embedded in 
   the pointer (PTR_ERR). Evaluate the return value using IS_ERR
   rather than checking for NULL.
   
   Fixes: 14911c6f48ec ("i2c: gpio: add fault injector")          
   Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>
   Cc: <stable@...r.kernel.org> # v4.16+
   Signed-off-by: Minjie Du <duminjie@...o.com>
   Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

I'm not sure whether Wolfram can fix it or, if you don't feel
lazy, you can send a v4.

> ---
> v1-v2:
> Fix judge typo.

Please update also the changelog, v2-v3 and v3-v4.

Thanks, Markus, for the suggestions.

Andi

> ---
>  drivers/i2c/busses/i2c-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index e5a5b9e8b..545927b96 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
>  	 */
>  	if (!i2c_gpio_debug_dir) {
>  		i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
> -		if (!i2c_gpio_debug_dir)
> +		if (IS_ERR(i2c_gpio_debug_dir))
>  			return;
>  	}
>  
> -- 
> 2.39.0
>