linux-kernel - Re: [PATCH v3] i2c: busses: fix parameter check in i2c_gpio_fault_injector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230713095310.mafkoqrjwhm5r4mf@intel.intel>
Date:   Thu, 13 Jul 2023 11:53:10 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Minjie Du <duminjie@...o.com>, linux-i2c@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        opensource.kernel@...o.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] i2c: busses: fix parameter check in
 i2c_gpio_fault_injector_init()

Hi Markus,

> > +++ b/drivers/i2c/busses/i2c-gpio.c
> > @@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
> >  	 */
> >  	if (!i2c_gpio_debug_dir) {
> >  		i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
> > -		if (!i2c_gpio_debug_dir)
> > +		if (IS_ERR(i2c_gpio_debug_dir))
> >  			return;
> >  	}
> 
> Will the development attention grow also for the exception handling
> which is missing here so far?

Well, it depends why you need to handle the error return. I think
it's not important if this fails... the only reason I would
handle the error here is to print a warning in dmesg.

Thank you,
Andi