[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1de2a372-e167-515d-0a0d-6fcad4a1e051@linaro.org>
Date: Thu, 13 Jul 2023 11:59:13 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: huaqian.li@...mens.com, wim@...ux-watchdog.org, linux@...ck-us.net,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org
Cc: huaqianlee@...il.com, nm@...com, vigneshr@...com,
kristo@...nel.org, linux-watchdog@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, jan.kiszka@...mens.com,
baocheng.su@...mens.com
Subject: Re: [PATCH v3 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for
WDIOF_CARDRESET
On 13/07/2023 11:51, huaqian.li@...mens.com wrote:
> From: Li Hua Qian <huaqian.li@...mens.com>
>
> TI RTI (Real Time Interrupt) Watchdog doesn't support to record the
> watchdog cause. Add a reserved memory to know the last reboot was caused
> by the watchdog card. In the reserved memory, some specific info will be
> saved to indicate whether the watchdog reset was triggered in last
> boot.
>
> Signed-off-by: Li Hua Qian <huaqian.li@...mens.com>
> ---
> .../devicetree/bindings/watchdog/ti,rti-wdt.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> index fc553211e42d..8c16fd3929ec 100644
> --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> @@ -34,6 +34,18 @@ properties:
> power-domains:
> maxItems: 1
>
> + memory-region:
> + maxItems: 1
> + description:
> + Contains the watchdog reserved memory. It is optional.
> + In the reserved memory, the specified values, which are
> + PON_REASON_SOF_NUM(0xBBBBCCCC), PON_REASON_MAGIC_NUM(0xDDDDDDDD),
> + and PON_REASON_EOF_NUM(0xCCCCBBBB), are pre-stored at the first
> + 3 * 4 bytes to tell that last boot was caused by watchdog reset.
> + Once the PON reason is captured by driver(rti_wdt.c), the driver
> + is supposed to wipe the whole memory region.
> +
> +
If there is going to be new version, only one blank line, not two.
In any case:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists