linux-kernel - [PATCH v1] fs: Fix error checking for d_hash_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 19:05:00 +0800
From:   Wang Ming <machel@...o.com>
To:     Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     opensource.kernel@...o.com, Wang Ming <machel@...o.com>
Subject: [PATCH v1] fs: Fix error checking for d_hash_and_lookup()

In case of failure, debugfs_create_dir() returns NULL or an error
pointer. Most incorrect error checks were fixed, but the one in
d_add_ci() was forgotten.

Fixes: d9171b934526 ("parallel lookups machinery, part 4 (and last)")
Signed-off-by: Wang Ming <machel@...o.com>
---
 fs/dcache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/dcache.c b/fs/dcache.c
index 52e6d5fdab6b..2f03e275d2e0 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -2220,7 +2220,7 @@ struct dentry *d_add_ci(struct dentry *dentry, struct inode *inode,
 	 * if not go ahead and create it now.
 	 */
 	found = d_hash_and_lookup(dentry->d_parent, name);
-	if (found) {
+	if (!IS_ERR_OR_NULL(found)) {
 		iput(inode);
 		return found;
 	}
-- 
2.25.1