[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d93e0a7b-7ee8-62ad-cf96-985ee5a8d432@collabora.com>
Date: Thu, 13 Jul 2023 13:14:43 +0200
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Fei Shao <fshao@...omium.org>
Cc: chunkuang.hu@...nel.org, p.zabel@...gutronix.de, airlied@...il.com,
daniel@...ll.ch, matthias.bgg@...il.com,
dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH 1/4] drm/mediatek: mtk_dpi: Simplify with
devm_drm_bridge_add()
Il 13/07/23 09:55, Fei Shao ha scritto:
> Hi Angelo,
>
> On Wed, Apr 12, 2023 at 7:53 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@...labora.com> wrote:
>>
>> Change drm_bridge_add() to its devm variant to slightly simplify the
>> probe function.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>> drivers/gpu/drm/mediatek/mtk_dpi.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
>> index 948a53f1f4b3..2d5f3fc34f61 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
>> @@ -1090,11 +1090,12 @@ static int mtk_dpi_probe(struct platform_device *pdev)
>> dpi->bridge.of_node = dev->of_node;
>> dpi->bridge.type = DRM_MODE_CONNECTOR_DPI;
>>
>> - drm_bridge_add(&dpi->bridge);
>> + ret = devm_drm_bridge_add(dev, &dpi->bridge);
>> + if (ret)
>> + return ret;
>
> And also drop the drm_bridge_remove() call in mtk_dpi_remove()?
>
Yes. V2 will drop that.
Cheers,
Angelo
> Regards,
> Fei
>
>>
>> ret = component_add(dev, &mtk_dpi_component_ops);
>> if (ret) {
>> - drm_bridge_remove(&dpi->bridge);
>> dev_err(dev, "Failed to add component: %d\n", ret);
>> return ret;
>> }
>> --
>> 2.40.0
>>
>>
>
Powered by blists - more mailing lists