linux-kernel - [PATCH] arm64: errata:#include <linux/cpufeature.h> instead of <asm/cpufeature.h> space required after that ','

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 19:36:49 +0800
From:   chenqingyun001@...suo.com
To:     catalin.marinas@....com, will@...nel.org
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] arm64: errata:#include <linux/cpufeature.h> instead of
 <asm/cpufeature.h>            space required after that ','

The linux/cpufeature.h header file is a more general and
standardized header file, which includes the cpufeature.h
header files under different architectures, while the
asm/cpufeature.h header file is a header file specific
to a certain architecture. There may be some
incompatibilities or outdated issues.
If commas are used to separate multiple parameters
or expressions, there should be a space after the
commas to maintain code readability and style consistency.


Signed-off-by: Qingyun Chen <chenqingyun001@...suo.com>
---
  arch/arm64/kernel/cpu_errata.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/kernel/cpu_errata.c 
b/arch/arm64/kernel/cpu_errata.c
index 307faa2b4395..9b19380629c1 100644
--- a/arch/arm64/kernel/cpu_errata.c
+++ b/arch/arm64/kernel/cpu_errata.c
@@ -10,7 +10,7 @@
  #include <linux/cpu.h>
  #include <asm/cpu.h>
  #include <asm/cputype.h>
-#include <asm/cpufeature.h>
+#include <linux/cpufeature.h>
  #include <asm/kvm_asm.h>
  #include <asm/smp_plat.h>

@@ -726,7 +726,7 @@ const struct arm64_cpu_capabilities arm64_errata[] = 
{
          .capability = ARM64_WORKAROUND_2658417,
          /* Cortex-A510 r0p0 - r1p1 */
          ERRATA_MIDR_RANGE(MIDR_CORTEX_A510, 0, 0, 1, 1),
-        MIDR_FIXED(MIDR_CPU_VAR_REV(1,1), BIT(25)),
+        MIDR_FIXED(MIDR_CPU_VAR_REV(1, 1), BIT(25)),
          .cpu_enable = cpu_clear_bf16_from_user_emulation,
      },
  #endif