linux-kernel - Re: [PATCH 45/58] mmc: usdhi60rol0: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230713114418.GC13100@axis.com>
Date:   Thu, 13 Jul 2023 13:44:18 +0200
From:   Jesper Nilsson <jesper.nilsson@...s.com>
To:     Yangtao Li <frank.li@...o.com>
CC:     Jesper Nilsson <jesper.nilsson@...s.com>,
        Lars Persson <lars.persson@...s.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, <linux-arm-kernel@...s.com>,
        <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 45/58] mmc: usdhi60rol0: Convert to platform remove
 callback returning void

On Thu, Jul 13, 2023 at 04:07:54PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Acked-by: Jesper Nilsson <jesper.nilsson@...s.com>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com