linux-kernel - Re: [PATCH 2/2] eventfd: simplify eventfd_signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 13:59:01 +0200
From:   Petr Machata <petrm@...dia.com>
To:     Christian Brauner <brauner@...nel.org>
CC:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] eventfd: simplify eventfd_signal_mask()


Christian Brauner <brauner@...nel.org> writes:

> @@ -82,9 +83,9 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask)
>   *
>   * Returns the amount by which the counter was incremented.

This should be reworded to reflect the fact that the function now
returns a bool.

>   */
> -__u64 eventfd_signal(struct eventfd_ctx *ctx)
> +bool eventfd_signal(struct eventfd_ctx *ctx)
>  {
> -	return eventfd_signal_mask(ctx, 1, 0);
> +	return eventfd_signal_mask(ctx, 0);
>  }
>  EXPORT_SYMBOL_GPL(eventfd_signal);
>