linux-kernel - Re: [PATCH] scsi/sg: fix checking return value of blk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <byd2qxkpr3hfwbwqvyfhzme5tj22ysl73anejw6wcrqnq5eh7k@datuhqcrjprq>
Date:   Thu, 13 Jul 2023 12:21:35 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Yu Kuai <yukuai1@...weicloud.com>
CC:     "mhartmay@...ux.ibm.com" <mhartmay@...ux.ibm.com>,
        "bblock@...ux.ibm.com" <bblock@...ux.ibm.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "hch@....de" <hch@....de>, "axboe@...nel.dk" <axboe@...nel.dk>,
        "yukuai3@...wei.com" <yukuai3@...wei.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi/sg: fix checking return value of blk_get_queue()

On Jul 05, 2023 / 10:40, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> Commit fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
> make a mess how blk_get_queue() is called, blk_get_queue() returns true
> on success while the caller expects it returns 0 on success.
> 
> Fix this problem and also add a corresponding error message on failure.
> 
> Fixes: fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
> Reported-by: Marc Hartmayer <mhartmay@...ux.ibm.com>
> Closes: https://lore.kernel.org/all/87lefv622n.fsf@linux.ibm.com/
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

I observed that /dev/sg* files are not created with kernel v6.5-rc1, and it
causes blktests scsi/002 failure. I confirmed this patch fixes it. Thanks.

Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>