linux-kernel - Re: [PATCH] selftests: Fix arm64 test installation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <620a5b91-9715-ee28-423c-851506b10832@linuxfoundation.org>
Date:   Fri, 14 Jul 2023 11:48:51 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     John Hubbard <jhubbard@...dia.com>,
        Mark Brown <broonie@...nel.org>, Shuah Khan <shuah@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Ryan Roberts <ryan.roberts@....com>
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: Fix arm64 test installation

On 7/13/23 14:16, John Hubbard wrote:
> On 7/13/23 13:02, Shuah Khan wrote:
>> On 7/10/23 08:04, Mark Brown wrote:
> ...
>>> -kernel_header_files:
>>> -    @ls $(KHDR_DIR)/linux/*.h >/dev/null 2>/dev/null;                      \
>>> -    if [ $$? -ne 0 ]; then                                                 \
>>> -            RED='\033[1;31m';                                                  \
>>> -            NOCOLOR='\033[0m';                                                 \
>>> -            echo;                                                              \
>>> -            echo -e "$${RED}error$${NOCOLOR}: missing kernel header files.";   \
>>> -            echo "Please run this and try again:";                             \
>>> -            echo;                                                              \
>>> -            echo "    cd $(top_srcdir)";                                       \
>>> -            echo "    make headers";                                           \
>>> -            echo;                                                              \
>>> -        exit 1; \
>>> -    fi
>>> -
>>> -.PHONY: kernel_header_files
>>> +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
>>>   define RUN_TESTS
>>>       BASE_DIR="$(selfdir)";            \
>>>
>>> ---
>>> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
>>> change-id: 20230710-kselftest-fix-arm64-c023160018d7
>>>
>>> Best regards,
>>
>> Thank you. Will apply the patch for the next rc
>>
>> thanks,
>> -- Shuah
> 
> Hi Shuah,
> 
> Actually, I was hoping that my two fixes [1], [2] could be used, instead
> of reverting the feature.
> 
> 
> [1] https://lore.kernel.org/all/20230711005629.2547838-1-jhubbard@nvidia.com/
> 
> [2] https://lore.kernel.org/all/20230712193514.740033-1-jhubbard@nvidia.com/
> 
> 

Thanks - I will go do that now.

Mark! Are you good with taking these two - do these fix the
problems you are seeing?

thanks,
-- Shuah