linux-kernel - Re: [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <k3szwvlfadcymr6yfxln7hsm4vcym6wauglhmkbhekrvnzuqvn@pygu7iybuldl>
Date:   Thu, 13 Jul 2023 20:20:15 -0700
From:   Bjorn Andersson <andersson@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     David Heidelberg <david@...t.cz>, Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: qcom,dwc3: document extcon property

On Thu, Jul 13, 2023 at 08:37:55AM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2023 01:59, David Heidelberg wrote:
> > The driver has support for it already. Only missing bit is dt-binding entry.
> 
> No, because the child node already has it. We do not need to extcons for
> one USB. Also another reason is that it should be deprecated.
> 

In the current design of the Linux dwc3 driver we actually need both
nodes to be extcon targets, as both device drivers needs to react to the
role change. So I think the patch accurately describes the intended
design of today.

That said, we do not want to do this for the Type-C case, where we use a
full port node. Combined with other reasons, we really should fix the
dwc3 driver model so that the core propagates the role changes to the
glue drivers, and as such I agree that we shouldn't pick this patch.

Regards,
Bjorn