linux-kernel - Re: [PATCH net 3/3] selftests: tc: add ConnTrack procfs kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c5a138d-e6f1-9085-d1a4-4b30334d2462@huawei.com>
Date:   Fri, 14 Jul 2023 11:25:03 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Matthieu Baerts <matthieu.baerts@...sares.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, Shuah Khan <shuah@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paul Blakey <paulb@...lanox.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        <mptcp@...ts.linux.dev>
CC:     Pedro Tammela <pctammela@...atatu.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH net 3/3] selftests: tc: add ConnTrack procfs kconfig



On 2023/7/14 5:16, Matthieu Baerts wrote:
> When looking at the TC selftest reports, I noticed one test was failing
> because /proc/net/nf_conntrack was not available.
> 
>    not ok 373 3992 - Add ct action triggering DNAT tuple conflict
>    	Could not match regex pattern. Verify command output:
>    cat: /proc/net/nf_conntrack: No such file or directory
> 
> It is only available if NF_CONNTRACK_PROCFS kconfig is set. So the issue
> can be fixed simply by adding it to the list of required kconfig.
> 
> Fixes: e46905641316 ("tc-testing: add test for ct DNAT tuple collision")
> Cc: stable@...r.kernel.org
> Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [1]
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> ---
>   tools/testing/selftests/tc-testing/config | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config
> index d1ad29040c02..71706197ba0f 100644
> --- a/tools/testing/selftests/tc-testing/config
> +++ b/tools/testing/selftests/tc-testing/config
> @@ -5,6 +5,7 @@ CONFIG_NF_CONNTRACK=m
>   CONFIG_NF_CONNTRACK_MARK=y
>   CONFIG_NF_CONNTRACK_ZONES=y
>   CONFIG_NF_CONNTRACK_LABELS=y
> +CONFIG_NF_CONNTRACK_PROCFS=y
>   CONFIG_NF_FLOW_TABLE=m
>   CONFIG_NF_NAT=m
>   CONFIG_NETFILTER_XT_TARGET_LOG=m
> 

Tested-by: Zhengchao Shao <shaozhengchao@...wei.com>