linux-kernel - Re: [PATCH v3 00/15] PCI: Define Intel PCI IDs and use them in drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <245f0248-b0ea-fae5-ce1b-6d4414277f36@intel.com>
Date:   Fri, 14 Jul 2023 21:03:53 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>
CC:     <alsa-devel@...a-project.org>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v3 00/15] PCI: Define Intel PCI IDs and use them in
 drivers

On 2023-07-14 10:24 PM, Amadeusz Sławiński wrote:
> PCI IDs for Intel HDA are duplicated across quite a few drivers, due to
> various configurations and historical reasons. Currently almost all uses
> of HDA PCI IDs have corresponding comment telling which platform it is.
> Additionally there are some inconsistencies between drivers about which
> ID corresponds to which device.
> 
> Simplify things, by adding PCI IDs to global header and make use of them
> in drivers. This allows for removal of comments by having IDs themselves
> being self explanatory. Additionally it allows for removal of existing
> inconsistencies by having one source of truth.

...

> Amadeusz Sławiński (15):
>    PCI: Sort Intel PCI IDs by number
>    PCI: Add Intel Audio DSP devices to pci_ids.h
>    ASoC: SOF: Remove unused Broxton PCI ID
>    ALSA: Remove unused Broxton PCI ID
>    ALSA: hda: Add controller matching macros
>    ALSA: hda: Use global PCI match macro
>    ALSA: hda/i915:  Use global PCI match macro
>    ASoC: Intel: Skylake: Use global PCI match macro
>    ALSA: intel-dsp-config: Convert to PCI device IDs defines
>    ALSA: hda: Convert to PCI device IDs defines
>    ASoC: Intel: avs: Convert to PCI device IDs defines
>    ASoC: Intel: avs: Convert to PCI device IDs defines
>    ASoC: Intel: Skylake: Convert to PCI device IDs defines
>    ASoC: SOF: Intel: Convert to PCI device IDs defines
>    ASoC: Intel: sst: Convert to PCI device IDs defines

Given the amount of talks we have had internally regarding this subject, 
to my best knowledge series looks good:

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>

Great initiative Amadeo and, good job.