linux-kernel - Re: [PATCH v3 2/3] arm64: dts: ti: Add reserved memory for watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b0e6961-1211-4765-2a63-4b69789dbbb3@roeck-us.net>
Date:   Fri, 14 Jul 2023 16:27:48 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Nishanth Menon <nm@...com>, huaqian.li@...mens.com
Cc:     wim@...ux-watchdog.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        huaqianlee@...il.com, vigneshr@...com, kristo@...nel.org,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        jan.kiszka@...mens.com, baocheng.su@...mens.com
Subject: Re: [PATCH v3 2/3] arm64: dts: ti: Add reserved memory for watchdog

On 7/14/23 15:52, Nishanth Menon wrote:
> On 17:51-20230713, huaqian.li@...mens.com wrote:
>> From: Li Hua Qian <huaqian.li@...mens.com>
> 
> I guess I should be explicit about this: Lets keep this dts patch as
> "DONOTMERGE" in subject line for driver subsystem maintainer (I don't
> want a repeat of cpufreq maintainers picking up dts and associated
> warnings that are now pending fixes), resubmit at next rc1 and I can
> queue up the dts once the maintainers pick up the driver and bindings.
> 

FWIW, I never pick up patches outside drivers/hwmon without explicit Ack
from responsible maintainers (and most definitely not dts patches unless
a maintainer responsible for the file(s) specifically asks me to do it
(which I think never happened).

Guenter

> Ref: https://lore.kernel.org/all/20230714084725.27847-1-krzysztof.kozlowski@linaro.org/
> 
>>
>> This patch adds a reserved memory for the TI AM65X platform watchdog to
>> reserve the specific info, triggering the watchdog reset in last boot,
>> to know if the board reboot is due to a watchdog reset.
>>
>> Signed-off-by: Li Hua Qian <huaqian.li@...mens.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> index e26bd988e522..4bb20d493651 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
>> @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@...00000 {
>>   			alignment = <0x1000>;
>>   			no-map;
>>   		};
>> +
>> +		/* To reserve the power-on(PON) reason for watchdog reset */
>> +		wdt_reset_memory_region: wdt-memory@...00000 {
>> +			reg = <0x00 0xa2200000 0x00 0x1000>;
>> +			no-map;
>> +		};
>>   	};
>>   
>>   	leds {
>> @@ -718,3 +724,7 @@ &mcu_r5fss0_core1 {
>>   			<&mcu_r5fss0_core1_memory_region>;
>>   	mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
>>   };
>> +
>> +&mcu_rti1 {
>> +	memory-region = <&wdt_reset_memory_region>;
>> +};
>> -- 
>> 2.34.1
>>
>