[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023071424-folic-boss-18e3@gregkh>
Date: Fri, 14 Jul 2023 06:44:44 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: liubin001@...suo.com
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Fwd: [PATCH] tty:Insert clk_put before return (clk) to release
memory
On Fri, Jul 14, 2023 at 12:30:14PM +0800, liubin001@...suo.com wrote:
>
> tty/serial:Insert clk_put before return (clk) to release memory
> Signed-off-by: Liu Bin <liubin001@...uo.com>
> ---
> drivers/tty/serial/bcm63xx_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/bcm63xx_uart.c
> b/drivers/tty/serial/bcm63xx_uart.c
> index 55e82d0bf92d..7353b683952d 100644
> --- a/drivers/tty/serial/bcm63xx_uart.c
> +++ b/drivers/tty/serial/bcm63xx_uart.c
> @@ -851,6 +851,7 @@ static int bcm_uart_probe(struct platform_device *pdev)
> clk = of_clk_get(pdev->dev.of_node, 0);
>
> if (IS_ERR(clk))
> + clk_put(clk);
> return -ENODEV;
>
> port->iotype = UPIO_MEM;
This obviously has not even been tested :(
Powered by blists - more mailing lists