[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2622f293-9de9-c876-2892-bb3a1747dae5@intel.com>
Date: Thu, 13 Jul 2023 17:04:44 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>,
"Shaopeng Tan" <tan.shaopeng@...fujitsu.com>,
Fenghua Yu <fenghua.yu@...el.com>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 17/19] selftests/resctrl: Move CAT/CMT test global vars
to function they are used in
Hi Ilpo,
On 7/13/2023 6:19 AM, Ilpo Järvinen wrote:
> CAT and CMT tests have count_of_bits, long_mask, cbm_mask, and
> cache_size global variables that can be moved into the sole using
> function.
>
> Make the global variables local variables of the relevant function to
> scope them better.
>
> While at it, move cache_size initialization into the declaration line.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
Reinette
Powered by blists - more mailing lists