linux-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <64b09dbb.630a0220.e80b9.e2ed@mx.google.com>
Date:   Fri, 14 Jul 2023 08:58:29 +0800
From:   luoruihong <colorsu1922@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     ilpo.jarvinen@...ux.intel.com, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, luoruihong@...omi.com,
        weipengliang@...omi.com, wengjinfei@...omi.com

gregkh@...uxfoundation.org, jirislaby@...nel.org,
linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org、
luoruihong@...omi.com,
weipengliang@...omi.com,
wengjinfei@...omi.com
Subject: Re: [PATCH v4] serial: 8250_dw: Preserve original value of DLF
 register
In-Reply-To: <ZLArgoe3TXF27gsE@...le.fi.intel.com>

On Thu, Jul 13, 2023 at 07:51:14PM +0300, Andy Shevchenko wrote:
> On Thu, Jul 13, 2023 at 08:42:36AM +0800, Ruihong Luo wrote:
> > Preserve the original value of the Divisor Latch Fraction (DLF) register.
> > When the DLF register is modified without preservation, it can disrupt
> > the baudrate settings established by firmware or bootloader, leading to
> > data corruption and the generation of unreadable or distorted characters.
>
> You forgot to add my tag. Why? Do you think the name of variable warrants this?
> Whatever,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> Next time if you don't pick up somebody's tag, care to explain in the changelog
> why.
>
> > Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> > Signed-off-by: Ruihong Luo <colorsu1922@...il.com>

I'm sorry, I didn't know about this rule. Thank you for helping me add
the missing tags back and for all your previous kind assistance.

--
Best Regards,
Ruihong Luo