linux-kernel - Re: Re: [PATCHv2 1/2] clk: rockchip: rk3588: make gate linked clocks ignore unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CA+VMnFy0Uix64PxLECFK9D8KBF1o34yo3L1t1zQrhV+N2Dipig@mail.gmail.com>
Date:   Fri, 14 Jul 2023 10:58:13 +0530
From:   Jagan Teki <jagan@...eble.ai>
To:     "zhangqing@...k-chips.com" <zhangqing@...k-chips.com>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        heiko <heiko@...ech.de>,
        linux-rockchip <linux-rockchip@...ts.infradead.org>,
        pgwipeout <pgwipeout@...il.com>,
        "finley.xiao" <finley.xiao@...k-chips.com>,
        mturquette <mturquette@...libre.com>, sboyd <sboyd@...nel.org>,
        Boris Brezillon <boris.brezillon@...labora.com>,
        linux-clk <linux-clk@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        kernel <kernel@...labora.com>,
        Vincent Legoll <vincent.legoll@...il.com>
Subject: Re: Re: [PATCHv2 1/2] clk: rockchip: rk3588: make gate linked clocks
 ignore unused

Hi,

On Fri, 14 Jul 2023 at 06:44, zhangqing@...k-chips.com
<zhangqing@...k-chips.com> wrote:
>
> Hi Sebastian,
>
> The clock needs to rely on two parent clocks, which is required by design.Refer to the attachment for details.
> Our internal branch is implemented using clk-link.c. Recently, I will implement the real GATE_LINK API according to upstream, without modifying DT.

Do you have a solution to share or any pointers? I tried to use
clk-link by dropping GATE_LINK from clk-rk3588.c however the issue
remains still as double-parenting is unsupportive. Did you add
double-parenting to the mainline clk tree? Other than that, I have
used existing clk and try to attach the link clock in conventional
clock way like

        vo1_grf: syscon@...a8000 {
                compatible = "rockchip,rk3588-vo-grf", "syscon";
                reg = <0x0 0xfd5a8000 0x0 0x100>;
                clocks = <&cru PCLK_VO1GRF>;
        };

This also seems similar issue.

Thanks,
Jagan.