linux-kernel - Re: [PATCH] erofs: deprecate superblock checksum feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b585c1b-1541-59ce-2886-0d96875bc362@linux.alibaba.com>
Date:   Fri, 14 Jul 2023 13:58:13 +0800
From:   Gao Xiang <hsiangkao@...ux.alibaba.com>
To:     Jingbo Xu <jefflexu@...ux.alibaba.com>, chao@...nel.org,
        huyue2@...lpad.com, linux-erofs@...ts.ozlabs.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] erofs: deprecate superblock checksum feature



On 2023/7/14 12:50, Jingbo Xu wrote:
> 
> 
> On 7/14/23 12:29 PM, Gao Xiang wrote:
>>
>>
>> On 2023/7/14 11:38, Jingbo Xu wrote:
>>> Later we're going to introduce fs-verity based verification for the
>>> whole image.  Make the superblock checksum feature deprecated.
>>
>> I'd suggest that
>>
>>
>> "Later we're going to try the self-contained image verification.
>>   The current superblock checksum feature has quite limited
>>   functionality, instead, merkle trees can provide better protection
>>   for image integrity.
>>
>>   Since the superblock checksum is a compatible feature, just
>>   deprecate now. "
>>   
> 
> Yeah, another concern is that xxhash is used in the following xattr name
> filter feature [1] which is on the way.  It may be redundant to use two
> hashing algorithms for one filesystem.

Please help add this to the commit message when the next version
is sent.

Thanks,
Gao Xiang